Fixed scale-agnostic image size comparison #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the code would compare UIImage size properties, which are not in pixel units but scale-dependent points.
This would cause issue if a test uses reference images generated using .none fileNameOptions and ran tests on 2x or 3x simulators: they would fail early because of the size comparison because of the scale difference.
This commit changes the logic to use CGImageGet{Width,Height} instead, which returns the actual pixel size (akin to use size * scale).
This change makes sense since the image comparison code actually uses CGImage pixel retrieving methods.
|
|
reidmain
pushed a commit
that referenced
this pull request
Sep 18, 2019
Added PR #100 as the first change that will make it into the next release.
lukaskukacka
pushed a commit
to lukaskukacka/ios-snapshot-test-case
that referenced
this pull request
Jan 3, 2020
Previously we would compare UIImage size properties, which are not in pixel units but scale-dependent points. This would cause issues if a test used reference images generated using .none fileNameOptions and ran tests on 2x or 3x simulators: they would fail early because of the size comparison because of the scale difference.
This commit changes the logic to use CGImageGet{Width,Height} instead, which returns the actual pixel size (akin to use size * scale) and is backwards compatible since the image comparison code actually uses CGImage pixel retrieving methods.
lukaskukacka
pushed a commit
to lukaskukacka/ios-snapshot-test-case
that referenced
this pull request
Jan 3, 2020
Added PR uber#100 as the first change that will make it into the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the code would compare UIImage size properties, which are not in pixel units but scale-dependent points.
This would cause issue if a test uses reference images generated using .none fileNameOptions and ran tests on 2x or 3x simulators: they would fail early because of the size comparison because of the scale difference.
This commit changes the logic to use CGImageGet{Width,Height} instead, which returns the actual pixel size (akin to use size * scale).
This change makes sense since the image comparison code actually uses CGImage pixel retrieving methods.