-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support taking snapshots in light and dark mode #125
base: main
Are you sure you want to change the base?
Conversation
} | ||
|
||
func FBSnapshotVerifyViewControllerForLightDarkMode(_ viewController: UIViewController, identifier: String? = nil, delay: TimeInterval = 0, perPixelTolerance: CGFloat = 0, overallTolerance: CGFloat = 0, file: StaticString = #file, line: UInt = #line) { | ||
if #available(iOS 13.0, *) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be better to mark the method as available in iOS 13+ only (and the method above) rather than having this no-op on iOS 12 and below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, thanks Nick!
@steve509 I think we have an issue when try to use
|
Any updates on approving this? :) |
Hi @ahmedAlmasri, I'm not seeing that error myself 🤔 . Is the snapshot test failing even if you re-take the image? Which snapshot image is it failing on, the light or dark image? |
Any updates on this? |
Is there anything I can do to help get this reviewed and approved? Please let me know. |
Happy to review it now, but a minor merge conflict — do you mind rebasing? |
976d902
to
a5b642a
Compare
Thanks @alanzeino, i've rebased. Please let me know if you have any questions. |
Hello 👋, I wanted to add support for taking snapshot tests for both light and dark mode.