Add an env var to not to save images in record mode #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just verify that the image is created but dont save images.
|
Burak Coskun seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
alanzeino
reviewed
Jan 24, 2019
| @@ -103,7 +103,11 @@ - (BOOL)compareSnapshotOfViewOrLayer:(id)viewOrLayer | |||
| error:(NSError **)errorPtr | |||
| { | |||
| if (self.recordMode) { | |||
| return [self _recordSnapshotOfViewOrLayer:viewOrLayer selector:selector identifier:identifier error:errorPtr]; | |||
| if ([self _saveImagesInRecordMode]) { | |||
There was a problem hiding this comment.
We should also provide a way to set this via a property, via FBSnapshotTestCase.
There was a problem hiding this comment.
then we can remove this one? just set it from there?
There was a problem hiding this comment.
I'm not sure it would work for our case, because we would want to set this outside of the testing code (i.e., via an env var set in the scheme), but if someone else wanted to use this it's good to give them options.
Add dontSaveImagesInRecordMode as a property to FBSnapshotTestCase and naturally to FBSnapshotTestController. In record mode, if this property set to NO then snapshot images are neither saved nor tested against reference images. They are just skipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just verify that the image is created but dont save images.