Construct Chart Label #1038
Merged
Construct Chart Label #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump for review? @benshope |
benshope
approved these changes
Nov 16, 2018
|
|
||
| import PropTypes from 'prop-types'; | ||
|
|
||
| class ChartLabel extends React.PureComponent { |
There was a problem hiding this comment.
Can't wait to bump this to 16.6 so we can use React.memo for this!
|
Please add support for x and y (in pixels) instead of percentages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the title prop on the axes component leaves something to be desired, so this PR adds a customizable label that you place where ever:
Before
After
