Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contour Series #441

Merged
merged 3 commits into from
Jun 19, 2017
Merged

Contour Series #441

merged 3 commits into from
Jun 19, 2017

Conversation

mcnuttandrew
Copy link
Contributor

@mcnuttandrew mcnuttandrew commented May 31, 2017

This PR adds a a contour-density series based on d3-contour. It acts a much improved version of the heatmap series. The example is a slightly different version of Bostock's Old faithful (https://bl.ocks.org/mbostock/e3f4376d54e02d5d43ae32a7cf0e6aa9). Open to API suggestions and comments!

contour

In the near future it could also get a canvas mode pretty easily. Still to do

  • Tests
  • Docs

This Address #419

Copy link
Contributor

@balthazar balthazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

]}
data={data}/>
<MarkSeries animation data={data} size={1} color={'#125C77'}/>
<Borders style={{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might probably be a good idea to add a global property all that all four side extend, to prevent redundancy in cases like this one

@balthazar
Copy link
Contributor

noice

@mcnuttandrew mcnuttandrew merged commit 1cc8faa into uber:master Jun 19, 2017
@mcnuttandrew mcnuttandrew deleted the contour branch June 19, 2017 17:54
ayarcohaila pushed a commit to ayarcohaila/react-vis that referenced this pull request Jun 30, 2021
ayarcohaila added a commit to ayarcohaila/react-vis that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants