thrift: Support health check type in Health endpoint #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the Health handler does not take any arguments, so there's no way to add the health check type (process vs traffic) to the existing handler. Add a new handler to accept health requests as an argument, which will contain the type of health check. This allows services to remain healthy according to the process health checks, while refusing traffic from producton.
Codecov Report
@@ Coverage Diff @@
## dev #696 +/- ##
=========================================
+ Coverage 87.1% 87.37% +0.27%
=========================================
Files 40 40
Lines 4047 4047
=========================================
+ Hits 3525 3536 +11
+ Misses 394 386 -8
+ Partials 128 125 -3
Continue to review full report at Codecov.
|
kriskowal
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Health handler does not take any arguments, so there's no
way to add the health check type (process vs traffic) to the existing
handler.
Add a new handler to accept health requests as an argument, which will
contain the type of health check.
This allows services to remain healthy according to the process health
checks, while refusing traffic from production.
This change includes the latest meta.thrift from tchannel