Sending a large error should mention that we're out of space #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The returned error now includes the underlying error from the typed writer, resulting in: > failed to create outbound error frame: no more room in buffer
prashantv
force-pushed
the
large_err_message
branch
from
e4699e4
to
2fb5bfb
Compare
Codecov Report
@@ Coverage Diff @@
## dev #716 +/- ##
==========================================
+ Coverage 86.78% 87.54% +0.76%
==========================================
Files 40 40
Lines 4056 4056
==========================================
+ Hits 3520 3551 +31
+ Misses 408 383 -25
+ Partials 128 122 -6
Continue to review full report at Codecov.
|
|
LGTM |
AllenLuUber
approved these changes
Sep 8, 2018
akshayjshah
approved these changes
Sep 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The returned error now includes the underlying error from the typed
writer, resulting in: