introspection: Introspect any channel by ID #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the introspection endpoint only lets you (fully) introspect the channel that received the request. This restricts introspection to only work for channels that listen, but there are some services that create multiple channels: 1 for listening, and then 1 per client. Since the per-client channels may not be listening, we can only get limited information on their state. Since we already have unique IDs for each channel (and this is exposed via the `includeOtherChannels`), provide a way to introspect a specific channel by ID. This is backwards compatible -- if no ID is specified, the current channel is introspected as it is today.
Codecov Report
@@ Coverage Diff @@
## dev #756 +/- ##
==========================================
+ Coverage 88.21% 88.48% +0.26%
==========================================
Files 40 40
Lines 4074 4090 +16
==========================================
+ Hits 3594 3619 +25
+ Misses 364 360 -4
+ Partials 116 111 -5
Continue to review full report at Codecov.
|
AllenLuUber
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the introspection endpoint only lets you (fully) introspect
the channel that received the request. This restricts introspection to
only work for channels that listen, but there are some services that
create multiple channels: 1 for listening, and then 1 per client.
Since the per-client channels may not be listening, we can only get
limited information on their state. Since we already have unique IDs
for each channel (and this is exposed via the
includeOtherChannels),provide a way to introspect a specific channel by ID.
This is backwards compatible -- if no ID is specified, the current
channel is introspected as it is today.