connection: Separate out lastActivity into recv and send activity #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #770 +/- ##
==========================================
+ Coverage 88.22% 88.39% +0.16%
==========================================
Files 41 41
Lines 4145 4161 +16
==========================================
+ Hits 3657 3678 +21
+ Misses 371 366 -5
Partials 117 117
Continue to review full report at Codecov.
|
witriew
force-pushed
the
topic/wit/lastactivity_ts
branch
2 times, most recently
from
30e81f2
to
8cd9d4e
Compare
witriew
changed the title
witriew
force-pushed
the
topic/wit/lastactivity_ts
branch
from
8cd9d4e
to
6489da6
Compare
prashantv
approved these changes
Mar 19, 2020
connection.go
Outdated
| func (c *Connection) updateLastActivitySend(frame *Frame) { | ||
| // Pings are ignored for last activity. | ||
| switch frame.Header.messageType { | ||
| case messageTypeCallReq, messageTypeCallReqContinue, messageTypeCallRes, messageTypeCallResContinue, messageTypeError: |
There was a problem hiding this comment.
since we consider the same frames in both cases, can we move that into a separate private function
witriew
force-pushed
the
topic/wit/lastactivity_ts
branch
from
6489da6
to
7e52273
Compare
err restarted |
witriew
force-pushed
the
topic/wit/lastactivity_ts
branch
from
7e52273
to
a933e2a
Compare
`lastActivity` recorded when the last receive or send activity occurred over its connection. Separate this out into `lastActivityRecv` and `lastActivitySend` to observe the last receives or sends allowing monitoring of the elapsed time between reading from the recv buffer and writing to the send buffer. This will provide information on how stalled either buffer is.
witriew
force-pushed
the
topic/wit/lastactivity_ts
branch
from
a933e2a
to
9c849e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lastActivityrecorded when the last receive or send activity occurred overits connection. Separate this out into
lastActivityRecvandlastActivitySendto observe the last receives or sends allowing monitoring ofthe elapsed time between reading from the recv buffer and writing to the send
buffer. This will provide information on how stalled either buffer is.