Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension packaging to build and test action #9

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

mnoah1
Copy link
Collaborator

@mnoah1 mnoah1 commented Jun 13, 2024

Update the github build and test action to include a packaging step.

  • Updating package.json to include dependencies needed for packaging
  • Updating vscodeignore, which is used to determine what gets included in the package. Most directories, especially node_modules, can be excluded as the extension.js already includes all packaged code, to keep extension size small.
  • On each job run, the action will include a packaged extension artifact uploaded on the job run. Example: https://github.com/uber/vscode-bazel-bsp/actions/runs/9502950897

@mnoah1 mnoah1 force-pushed the mnoah1/packaging-updates branch from 050e837 to f1aecf1 Compare June 13, 2024 16:02
@mnoah1 mnoah1 marked this pull request as ready for review June 13, 2024 16:10
Copy link
Collaborator

@shuklahy shuklahy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnoah1 mnoah1 force-pushed the mnoah1/packaging-updates branch from f1aecf1 to 7849caa Compare June 13, 2024 17:57
@mnoah1 mnoah1 force-pushed the mnoah1/packaging-updates branch from 7849caa to e562bcb Compare June 13, 2024 18:07
@mnoah1 mnoah1 merged commit 2f6d85d into main Jun 13, 2024
4 checks passed
@mnoah1 mnoah1 deleted the mnoah1/packaging-updates branch June 13, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants