update_info_json method is added to update and add the additional inf… #92
Conversation
…ormation in the info.json file
There was a problem hiding this comment.
I would prefer not to add start_time and end_time to the class instance (self) as this information is specific to one call of drive, not the lifetime of the class, which we can use for multiple consecutive drives.
I would also like to indicate failed status in the info json.
The changes are not currently reflected in schedule. We have to write the initial info json. We can't add anything about success or runtime as we don't know those.
|
The missing |
|
@samjrholt Short summary: We should deprecate the individual We also move writing the info.json file from the individual calculators to the base class (all required calculator-specific details are available in the base class). |
There was a problem hiding this comment.
@lang-m @kzqureshi This looks good, the only other thing that I think could be useful to add to the JSON is the version of ubermag being used. That way, in the future, we know what versions of software (e.g. micromagnetic data) are compatible with the structure of the data/files
|
@samjrholt You are right, we should add the ubermag version. Maybe best |
…romagneticmodel into add_more_detail_to_info_json
| assert "end_time" in info | ||
| assert "elapsed_time" in info | ||
| assert "success" in info | ||
| assert info["success"] is True |
There was a problem hiding this comment.
| assert info["success"] is True | |
| assert info["success"] |
| # assumption: this test runs in under one minute | ||
| assert elapsed_seconds < 60 | ||
| else: | ||
| raise TypeError("Unexpected format for elapsed_time") |
There was a problem hiding this comment.
Where/when does this happen (in the tests)?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #92 +/- ##
==========================================
- Coverage 99.16% 98.58% -0.58%
==========================================
Files 30 30
Lines 597 637 +40
==========================================
+ Hits 592 628 +36
- Misses 5 9 +4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
closes |
update_info_json method is added to update and add the additional information to the info.json file.