Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for vector-valued ZhangLi u #48

Merged
merged 8 commits into from
Jul 22, 2024
Merged

Test for vector-valued ZhangLi u #48

merged 8 commits into from
Jul 22, 2024

Conversation

lang-m
Copy link
Member

@lang-m lang-m commented Mar 23, 2024

This is related to ubermag/micromagneticmodel#75 and ubermag/oommfc#133

Merging this test will also require some changes in mumax3c: either we can support the same functionality or disable the test. I will try that when I am on a suitable machine.

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3fe64cb) to head (7c2c39e).

Current head 7c2c39e differs from pull request most recent head 72b892d

Please upload reports for the commit 72b892d to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #48   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           14        14           
=========================================
  Hits            14        14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lang-m
Copy link
Member Author

lang-m commented Jun 9, 2024

@samjrholt Can you please review the new test test_vector_scalar.

@lang-m
Copy link
Member Author

lang-m commented Jul 14, 2024

I re-wrote all tests for Zhang Li, the diff is not really meaningful. The new tests all check some sort of DW motion.

Testing the new methods with mumax3c remains to be done.

@lang-m lang-m requested review from samjrholt and removed request for swapneelap July 14, 2024 12:23
to hopefully more meaningful names
@lang-m
Copy link
Member Author

lang-m commented Jul 14, 2024

Support in mumax3c is implemented in ubermag/mumax3c#88

Copy link
Member

@samjrholt samjrholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. Should we also have a test with a vector field? I think that is the only case which isn't covered at the moment.

micromagnetictests/calculatortests/zhangli.py Show resolved Hide resolved
micromagnetictests/calculatortests/zhangli.py Outdated Show resolved Hide resolved
Co-authored-by: Sam Holt <48217392+samjrholt@users.noreply.github.com>
@lang-m lang-m merged commit 3d1ed2d into master Jul 22, 2024
7 checks passed
@lang-m lang-m deleted the generalised_zhang_li branch July 22, 2024 14:53
@samjrholt
Copy link
Member

Looks good in general. Should we also have a test with a vector field? I think that is the only case which isn't covered at the moment.

@lang-m did you implement this or decide it wasn't needed?

@lang-m
Copy link
Member Author

lang-m commented Jul 22, 2024

There was a test already: test_field_vector_u. Current is just in x direction but that should not matter because we mainly need to tests our conversion code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants