Remove unnecessary code and optimize data retrieval

ubeydeozdmr · Feb 29, 2024 · c772969 · c772969
1 parent e7f99a8
commit c772969
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 48 deletions.
diff --git a/src/utils/getDB.js b/src/utils/getDB.js
diff --git a/src/v1/data/Districts.js b/src/v1/data/Districts.js
@@ -164,16 +164,6 @@ exports.getExactDistrict = function (id, fields) {
 
     const district = data.find((item) => item.id === +id);
 
-    // const districtNeighborhoods = neighborhoods.filter(
-    //   (neighborhood) => neighborhood.districtId === district.id,
-    // );
-    // district.neighborhoods = districtNeighborhoods;
-
-    // const districtVillages = villages.filter(
-    //   (village) => village.districtId === district.id,
-    // );
-    // district.villages = districtVillages;
-
     const districtNeighborhoods = neighborhoods
       .filter((neighborhood) => neighborhood.districtId === district.id)
       .map(({ id, name, population }) => ({ id, name, population }));

diff --git a/src/v1/data/Provinces.js b/src/v1/data/Provinces.js
@@ -189,40 +189,26 @@ exports.getExactProvince = function (id, fields, extend) {
     const provinceDistricts = districts.filter(
       (district) => district.provinceId === province.id,
     );
-    // console.log(provinceDistricts);
-    // province.districts = provinceDistricts;
-
-    // if (extend === 'true') {
-    //   province.districts.forEach((district) => {
-    //     const districtNeighborhoods = neighborhoods.filter(
-    //       (neighborhood) => neighborhood.districtId === district.id,
-    //     );
-    //     district.neighborhoods = districtNeighborhoods;
-
-    //     const districtVillages = villages.filter(
-    //       (village) => village.districtId === district.id,
-    //     );
-    //     district.villages = districtVillages;
-    //   });
-    // }
 
     province.districts = provinceDistricts.map(
       ({ id, name, population, area }) => ({ id, name, population, area }),
     );
 
-    province.districts.forEach((district) => {
-      const districtNeighborhoods = neighborhoods
-        .filter((neighborhood) => neighborhood.districtId === district.id)
-        .map(({ id, name, population }) => ({ id, name, population }));
+    if (extend === 'true') {
+      province.districts.forEach((district) => {
+        const districtNeighborhoods = neighborhoods
+          .filter((neighborhood) => neighborhood.districtId === district.id)
+          .map(({ id, name, population }) => ({ id, name, population }));
 
-      district.neighborhoods = districtNeighborhoods;
+        district.neighborhoods = districtNeighborhoods;
 
-      const districtVillages = villages
-        .filter((village) => village.districtId === district.id)
-        .map(({ id, name, population }) => ({ id, name, population }));
+        const districtVillages = villages
+          .filter((village) => village.districtId === district.id)
+          .map(({ id, name, population }) => ({ id, name, population }));
 
-      district.villages = districtVillages;
-    });
+        district.villages = districtVillages;
+      });
+    }
 
     if (fields) {
       const fieldsArray = fields.split(',');