Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it work with react 0.14.0-beta3 #27

Closed
boosh opened this issue Aug 23, 2015 · 8 comments
Closed

Make it work with react 0.14.0-beta3 #27

boosh opened this issue Aug 23, 2015 · 8 comments

Comments

@boosh
Copy link

boosh commented Aug 23, 2015

Great library. I'd love to use it, but I'm a react noob. I can't get this to work with my project based on relay-starter-kit, which uses react 0.14.0-beta3. For some reason, I can't get anything useful to install when I fork and upgrade the dependency. When I install via npm (there's no actual source, just the meta files like package.json).

A fix (maybe an alternative branch) would be very helpful.

Thanks!

@ro-ka
Copy link
Contributor

ro-ka commented Aug 26, 2015

When you install with npm, there should be a module folder which contains the code. Not the ES6 source code, but the ES5 compiled code.

I’m not sure why it shouldn’t work with React 0.14. Is there any error thrown?

There is no official changelog yet, so I won’t make changes now. But there will be an update when React 0.14 is released officially.

If you find out what causes the problems, let me know!

@TylerBrock
Copy link

bump

@ro-ka
Copy link
Contributor

ro-ka commented Oct 8, 2015

Did someone fine out what’s wrong? The module folder should be in an npm install and be loaded.

@leoasis
Copy link

leoasis commented Oct 9, 2015

I think the problem the user is having is when installing via npm with the path pointing to the forked repo url. Since the modules dir is not in git (is created in a task before publishing the package) it does not appear in node_modules after npm install. Also the rest of the files in .npmignore are, well, ignored as well so it only contains the package.json and some other files.

So, to sum up, it should work as is with React 0.14 (after a version bump in the peer dependencies, @ro-ka), and @boosh in your fork you need to add the modules folder as part of your git repo and push the built bundle.

ro-ka added a commit that referenced this issue Oct 12, 2015
@ro-ka
Copy link
Contributor

ro-ka commented Oct 12, 2015

So the peer dependency got bumped to 0.14.0. For me it is working… Can you confirm?

@ro-ka
Copy link
Contributor

ro-ka commented Oct 15, 2015

Suspect that it is working. Reopen, if not.

@ro-ka ro-ka closed this as completed Oct 15, 2015
@leoasis
Copy link

leoasis commented Oct 15, 2015

@ro-ka sorry for not reaching back, didn't actually use the released version until yesterday. Working fine for me! :D

@ro-ka
Copy link
Contributor

ro-ka commented Oct 15, 2015

Great to hear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants