test: refactor tests with expectEmit

[rndquu]

In the latest foundry version the tests are failing with:

Encountered 1 failing test in test/diamond/facets/BondingCurveFacet.t.sol:ZeroStateBonding
[FAIL. Reason: Expected an emit, but no logs were emitted afterward. You might have mismatched events or not enough events were emitted. Counterexample: calldata=0x5fffbbe400000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000, args=[0, 0]] testDeposit(uint32,uint256) (runs: 0, μ: 0, ~: 0)

Encountered 1 failing test in test/diamond/facets/StakingFacet.t.sol:ZeroStateStakingTest
[FAIL. Reason: Expected an emit, but no logs were emitted afterward. You might have mismatched events or not enough events were emitted. Counterexample: calldata=0xc237edba00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000, args=[0, 0]] testDeposit_Staking(uint256,uint256) (runs: 0, μ: 0, ~: 0)

It happens because vm.expectEmit() now works only for the next call

This PR refactors vm.expectEmit() to be called right before a function that emits an expected event

[ubiquibot]

Deployment: Thu May 25 2023 14:15:25 (UTC)