Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

624, 643 - fix git submodules #665

Closed
wants to merge 19 commits into from

Conversation

PhantomCracker
Copy link
Contributor

@PhantomCracker PhantomCracker commented Jun 1, 2023

Resolves #624 and #643

@ubiquibot
Copy link

ubiquibot bot commented Jun 1, 2023

@PhantomCracker
Copy link
Contributor Author

@zgorizzo69 any news on this pull request?

@0x4007 0x4007 requested a review from rndquu June 3, 2023 06:05
@0x4007
Copy link
Member

0x4007 commented Jun 3, 2023

@rndquu could you take over this pull request?

@PhantomCracker PhantomCracker changed the title 624 - fix git submodules 624, 643 - fix git submodules Jun 3, 2023
Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PhantomCracker

Libs are not updated though their branches are set

Could you:

  1. run forge update to update libs to the specified branches
  2. run forge test to check that nothing is broken
  3. commit changes in the libs folder

.gitmodules Show resolved Hide resolved
@PhantomCracker
Copy link
Contributor Author

@PhantomCracker

Libs are not updated though their branches are set

Could you:

  1. run forge update to update libs to the specified branches
  2. run forge test to check that nothing is broken
  3. commit changes in the libs folder

I have updated the pull request.

@0x4007 0x4007 requested a review from rndquu June 6, 2023 04:12
@rndquu
Copy link
Member

rndquu commented Jun 6, 2023

@PhantomCracker
Libs are not updated though their branches are set
Could you:

  1. run forge update to update libs to the specified branches
  2. run forge test to check that nothing is broken
  3. commit changes in the libs folder

I have updated the pull request.

This build workflow is failng https://github.com/ubiquity/ubiquity-dollar/actions/runs/5181665522/jobs/9337474556?pr=665, pls fix it

@PhantomCracker
Copy link
Contributor Author

PhantomCracker commented Jun 6, 2023

Hei @rndquu ,
In order to update the required libs, I need some help with contracts.
If needed only for this issue, we need to revert to this commit: f428f49

Later edit: I have already reversed the commits

@rndquu
Copy link
Member

rndquu commented Jun 19, 2023

closing because of inactivity

@rndquu rndquu closed this Jun 19, 2023
@0x4007
Copy link
Member

0x4007 commented Jun 19, 2023

I thought the bot was able to handle this already?

@rndquu
Copy link
Member

rndquu commented Jun 19, 2023

I thought the bot was able to handle this already?

hard to say, we already have a task that might make the unassignment better ubiquity/ubiquibot#408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix git submodules
4 participants