Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packet.rs: add cfgtimemode2 and cfgtimemode3 frames #27

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

gwbres
Copy link
Collaborator

@gwbres gwbres commented Jun 23, 2022

Hello @lkolbly @reitermarkus ,

congratulations for this amazing lib πŸš€ πŸ›°οΈ !

With this contribution, I would like to introduce two configuration frames that are specific to Timing class receivers:

  • CfgTmode2
  • CfgTmode3

For datafields that might have two roles, like ecef_x_or_lat_hp (ECEF coordinates or latitude coordinate), I use a scaling of 1.0 and documented the units properly.

I closed the previous pull request because I had too much rework to reach something valuable.

Copy link
Collaborator

@lkolbly lkolbly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Sorry it's taken me so long to get to your PRs

@lkolbly lkolbly merged commit e80f2cb into ublox-rs:master Sep 11, 2022
@gwbres
Copy link
Collaborator Author

gwbres commented Sep 11, 2022

Thank you! Sorry it's taken me so long to get to your PRs

Hello @lkolbly,
No worries, I can still have our application rely on my fork. But with the latest contributions, this is already looking quite good. I will look into in details, thank you for spending some time on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants