Implement CfgValGet request and response, and NavSvIn #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NavHpPosEcef` `flags` field to type `NavHpPosEcefFlags`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added some associated configuration Key enums.
I have test these changes on my F9P device but don't have any others to work with. I've been working with https://cdn.sparkfun.com/assets/f/7/4/3/5/PM-15136.pdf as the spec and I'm not aware of what other gotchas there may be, so any feedback welcome.
The Wildcard query isn't working right now because not all keys are implemented in this library - the variable length encoding requires knowledge of the length of each key, so parsing has to abort when it hits an unknown key.
Let me know if you have any comments on style etc and if this is useful!