Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reorder the build steps to save time and image size #1778

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

antheas
Copy link
Contributor

@antheas antheas commented Oct 25, 2024

Podman uses an inferior gzip compression to ostree-rs-ext, which adds 500mb to the image. In addition, pulling the image to podman requires 3 min. So reorder the steps to save some time and image space.

Looking at the action again it takes only 2.5 min and uploading with podman is slightly faster so it might not be worth it.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 25, 2024
@antheas antheas marked this pull request as draft October 25, 2024 22:15
@antheas antheas closed this Oct 25, 2024
@antheas antheas reopened this Oct 30, 2024
@antheas antheas marked this pull request as ready for review October 30, 2024 18:38
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 30, 2024
@KyleGospo KyleGospo merged commit 7324878 into ublue-os:testing Oct 30, 2024
1 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants