feat(just): Improve install speaker firmware #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re running. also makes the just dynamic so new firmware can be added without updating the just file, hence the preview before running.
dosubot
bot
added
size:S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@antheas pointed out I had typoed the original ujust so i have to just live with it.
This improves the
install-speaker-firmareto be correctly spelledinstall-speaker-firmwareand also makes the ujust recipe more dynamic so it does not have to be updated when new speaker firmware is added.Since this script will be loaded externally it will also be displayed to the user for visual verification before running (unless the
yesor-yaction is passed)if this is to be added to yafti then it has to be called with
sudo -A ujust install-speaker-firmware yesin the terminal
ujust install-speaker-firmware yeswill be preferred as it will ask for sudo when needed (and avoiding "teaching" users that some ujusts should be run with sudo... which then causes them to use it on all of them...)