feat(ujust): make setup-cockpit work more consistently and track container existence #1998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
|
|
befanyt
reviewed
Dec 2, 2024
Co-authored-by: befanyt <172807209+befanyt@users.noreply.github.com>
tulilirockz
force-pushed
the
better-setup-cockpit
branch
from
db7408e to
f73a76d
Compare
castrojo
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1995. Tracking the container existence makes it so the user can know if the webui is even up or not, the service itself doesn't seem to do much
I also removed the pmlogger thing because I dont know if it is necessary...? Cockpit seems to work fine without that, it didnt seem to work before anyways