This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
feat: Add Secure Boot Support and Remove Grub Entry for Test this Media #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to add secure boot support and remove the grub entry that does not currently work for the ISO installer. These were the last 2 items that needed to be fixed before we consider our ISOs good to ship. We are fast tracking this change in order to make sure we are ready for upcoming conferences (KubeCon and SCALE)
What was done
Secure Boot Support
Secure boot support is using the method we previously used in our old Isogenerator to enable secure boot support. This imports our key on the users system on first boot if secure boot is detected and opens mokutil to walk the user through importing it.
Removing Grub Entry
Current method for fixing this is by removing the entry in the template config file for both
grub2-bios.cfg
andgrub2-efi.cfg
using sed command. There is probably a way to override the config file, but this will work for now.Conclusion
With these final 2 issues sorted out, I feel comfortable with shipping the new ISOs for Bluefin and Bazzite. We will come back to optimize at a later date.