Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ucore/packages.json: Add NetworkManager-wifi #140

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

travier
Copy link
Contributor

@travier travier commented Apr 3, 2024

Add NetworkManager-wifi for a better wifi management experience.


Based on #139 for convenience.

See: #138
See: coreos/fedora-coreos-tracker#862

@travier travier marked this pull request as draft April 4, 2024 08:28
@bsherman
Copy link
Collaborator

bsherman commented Apr 8, 2024

There was also a comment about adding iwd on the issue which spawned this PR: #138 (comment) .

I'd like to get feedback from some users of ucore before we proceed with adding either NetworkManager-wifi or iwd to ucore. If we do add iwd, I want it to be added at the same time as NetworkManager-wifi.

@travier
Copy link
Contributor Author

travier commented Apr 8, 2024

I think it's independent. You would want NetworkManager-wifi in all cases to manage wifi devices using NetworkManager.

Add NetworkManager-wifi for a better wifi management experience.
@travier travier force-pushed the main-networkmanager-wifi branch from 381436a to c4f0c1d Compare April 8, 2024 15:14
@travier travier marked this pull request as ready for review April 8, 2024 15:14
@bsherman
Copy link
Collaborator

bsherman commented Apr 8, 2024

I think it's independent. You would want NetworkManager-wifi in all cases to manage wifi devices using NetworkManager.

Agreed using NetworkManager-wifi to manage is preferred.

The reason I'm linking them is if a user first runs wpa_supplicant as the NetworkManager-wifi backend, the PSK for a given SSID will be remembered in /etc/NetworkManager/system-connections allowing for auto-reconnect after reboot, etc. But if iwd is then added to the image, the connection for that remembered SSID will fail after reboot because iwd additionally stores the PSK in /var/lib/iwd and uses that value rather than the value stored bye NetworkManager.

So, while iwd works great as a backend, the migration would likely be an unpleasant surprise to any user.

@travier
Copy link
Contributor Author

travier commented Apr 8, 2024

I think we should considerate both independently. There are no timeline nor work in progress right now for iwd inclusion so this is about improving the status quo. We can look at the iwd transition if and when it happens. We can even consider keeping both in the image and let users make their own choice as iwd does not cover 100% use cases from wpa_supplicant as far as I remember.

Overall it's up to you, but I don't know how would users be expected to manage their wifi interfaces right now on ucore if they don't have this package installed.

@bsherman
Copy link
Collaborator

bsherman commented Apr 9, 2024

I think we should considerate both independently. There are no timeline nor work in progress right now for iwd inclusion so this is about improving the status quo. We can look at the iwd transition if and when it happens. We can even consider keeping both in the image and let users make their own choice as iwd does not cover 100% use cases from wpa_supplicant as far as I remember.

After soliciting feedback from some users, there's pretty clear interest in adding NetworkManager-wifi, while iwd is less specifically requested.

I do agree, both wpa_supplicant and iwd could exist on image and user could chose to configure iwd if required/desired, but we can still leave that for a separate request.

Overall it's up to you, but I don't know how would users be expected to manage their wifi interfaces right now on ucore if they don't have this package installed.

Until now, I would assume users have layered packages or built custom images on top of ucore.

@bsherman bsherman enabled auto-merge (squash) April 9, 2024 14:16
@bsherman bsherman merged commit 772825a into ublue-os:main Apr 9, 2024
36 of 37 checks passed
@travier travier deleted the main-networkmanager-wifi branch April 9, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants