Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add zfs-dracut to fedora-coreos and ucore #186

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

twiest
Copy link
Contributor

@twiest twiest commented Aug 17, 2024

Add zfs-dracut to fedora-coreos and ucore. zfs-dracut is necessary to include zfs when rebuilding initrd.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. zfs labels Aug 17, 2024
Add zfs-dracut to fedora-coreos and ucore. zfs-dracut is necessary to
include zfs when rebuilding initrd.
@bsherman
Copy link
Collaborator

Add zfs-dracut to fedora-coreos and ucore. zfs-dracut is necessary to include zfs when rebuilding initrd.

@twiest thank you for the PR!

I wonder... we haven't yet done it in ucore, but the atomic desktop images in ublue-os org rebuild the initrd as part of image build.

see: https://github.com/ublue-os/main/blob/main/initramfs.sh

I am thinking the package addition makes sense as you've done it, but also, we could rebuild initrd as part of the ucore builds and pre-include zfs so a user need not do so. I wouldn't do this on the fedora-coreos images, because my intent with those is to do no more than install the minimally required packages.

Thoughts?

@twiest
Copy link
Contributor Author

twiest commented Aug 31, 2024

I love that idea!

I believe I would personally still need this as I rebuild the initrd myself for other reasons (like adding more dirs to / for mounting points before it is set read-only).

@bsherman
Copy link
Collaborator

bsherman commented Sep 2, 2024

I believe I would personally still need this as I rebuild the initrd myself for other reasons (like adding more dirs to / for mounting points before it is set read-only).

Ok, for now, we can approve and merge this as is, we'll consider the build time re-generation of initramfs as a distinct issue.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 2, 2024
@bsherman bsherman merged commit aeacfa5 into ublue-os:main Sep 2, 2024
30 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. zfs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants