Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-ui): add fields in InputDescription with InputFieldDescription data structures to describe the fields of an input demand in detail #182

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

sassanh
Copy link
Collaborator

@sassanh sassanh commented Oct 12, 2024

image

…ription` data structures to describe the fields of an input demand in detail
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...vices/030-wifi/pages/create_wireless_connection.py 14.28% 6 Missing ⚠️
Flag Coverage Δ
ubuntu-latest 58.42% <83.33%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ubo_app/services/010-voice/setup.py 56.89% <100.00%> (+0.37%) ⬆️
ubo_app/services/040-camera/reducer.py 44.89% <ø> (ø)
ubo_app/services/080-docker/images_.py 100.00% <ø> (ø)
ubo_app/services/080-docker/setup.py 44.95% <100.00%> (+0.50%) ⬆️
ubo_app/store/operations.py 100.00% <100.00%> (ø)
ubo_app/utils/input.py 39.62% <100.00%> (+4.92%) ⬆️
...vices/030-wifi/pages/create_wireless_connection.py 46.15% <14.28%> (+1.05%) ⬆️

Copy link
Collaborator

@mehrdadfeller mehrdadfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only had one minor typo fix. everything else looks good. please merge

ubo_app/services/010-voice/setup.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Use dropdown menu or info text to explain possible values for Type and Hidden field values in WiFi
2 participants