Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement compatible_installer #176

Merged
merged 15 commits into from
Mar 21, 2022
Merged

Implement compatible_installer #176

merged 15 commits into from
Mar 21, 2022

Conversation

NeoTheThird
Copy link
Member

@NeoTheThird NeoTheThird requested a review from Flohack74 March 20, 2022 13:43
v2/checkSemver.js Outdated Show resolved Hide resolved
v2/checkSemver.js Outdated Show resolved Hide resolved
@NeoTheThird
Copy link
Member Author

Alright, this has gotten interesting! I finally looked into writing ajv plugins for more advanced schema validations. this now allows us to specify a ubports_installer-compatibility semver range in the schema of every action and to validate that the compatible_installer semver range specified on an operating_system of a device config is a subset of this. Straightforward syntax, straightforward validation.

The scaffolding of this plugin can be used to do much more validation later, very excited to see where this will go!

@NeoTheThird NeoTheThird merged commit ca6d15a into master Mar 21, 2022
@NeoTheThird NeoTheThird deleted the semver branch March 21, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants