Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Allow to show hidden channes using envar #2432

Closed
wants to merge 1 commit into from

Conversation

mariogrip
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #2432 (624b094) into master (d687ec3) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2432      +/-   ##
==========================================
+ Coverage   73.71%   73.74%   +0.02%     
==========================================
  Files          28       28              
  Lines         917      918       +1     
==========================================
+ Hits          676      677       +1     
  Misses        241      241              
Impacted Files Coverage Δ
src/core/plugins/systemimage/api.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d687ec3...624b094. Read the comment docs.

Copy link
Member

@NeoTheThird NeoTheThird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually use cli flags for such things

NeoTheThird added a commit that referenced this pull request Mar 16, 2022
hidden channels are presented in a separate section at the end of the dropdown.
Replaces #2432.
@NeoTheThird
Copy link
Member

superceded by #2503

@NeoTheThird NeoTheThird deleted the hidden-chan-env branch March 16, 2022 13:46
NeoTheThird added a commit that referenced this pull request Mar 21, 2022
* Show hidden systemimage channels
hidden channels are presented in a separate section at the end of the dropdown.
Replaces #2432.

* implement hidden channels setting
llewelld pushed a commit to llewelld/ubports-installer that referenced this pull request Apr 26, 2022
* Show hidden systemimage channels
hidden channels are presented in a separate section at the end of the dropdown.
Replaces ubports#2432.

* implement hidden channels setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants