Introduce CLI flag for systemimage server urls #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2504 +/- ##
=======================================
Coverage 74.28% 74.28%
=======================================
Files 29 29
Lines 941 941
=======================================
Hits 699 699
Misses 242 242
Continue to review full report at Codecov.
|
Flohack74
approved these changes
Mar 20, 2022
llewelld
pushed a commit
to llewelld/ubports-installer
that referenced
this pull request
Apr 26, 2022
* Allow to override default system-image server using envar * Introduce CLI flag for systemimage server urls supercedes ubports#2101 * Fix test * fix more tests when running on ci Co-authored-by: Marius Gripsgard <marius@ubports.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supercedes #2101.
Use
npm start -- --systemimage "https://wherever.xyz"for custom settings.