Move user name comparison to provider #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adombeck
force-pushed
the
do-not-case-fold-username
branch
4 times, most recently
from
cdc34cb to
a29e9b9
Compare
|
The implementation of the user name check depends on which field we retrieve the username from, so I'll keep this as Draft until https://warthogs.atlassian.net/browse/UDENG-4413 is done. |
adombeck
force-pushed
the
do-not-case-fold-username
branch
from
a29e9b9 to
8889823
Compare
|
We decided to go ahead with this and, if needed, change the check after https://warthogs.atlassian.net/browse/UDENG-4413 is done. |
denisonbarbosa
requested changes
Sep 9, 2024
adombeck
force-pushed
the
do-not-case-fold-username
branch
2 times, most recently
from
8ff34a8 to
bc0d4a4
Compare
The decision whether two usernames are considered equal is provider-specific. For example, some providers have case-insensitive usernames. UDENG-4414
adombeck
force-pushed
the
do-not-case-fold-username
branch
from
bc0d4a4 to
5a8cafb
Compare
|
I added a commit which checks that the usernames comply with the Microsoft Entra username policy (see UDENG-4517). |
We must avoid that multiple users of the provider map to the same local user. We currently use `strings.EqualFold` to compare the usernames, which considers some different Unicode characters the same (for example the "KELVIN SIGN" (U+212A) and the ASCII "K"). To avoid that, we considered using a custom `toLowercase` function which only converts ASCII characters to lowercase. However, we can just check if the username is valid under the Microsoft Entra username policy. Microsoft Entra enforces the username policy for the User Principal Name (UPN). We currently don't use the UPN as the username though, we use the `preferred_username` field from the ID token. The value of that field is equal to the UPN in some cases, in other cases it's equal to the user's email address. It's not clear if the username policy is enforced for all possible values of the `preferred_username` field. So to ensure that we don't have to care about the Unicode case-folding when comparing the usernames, we enforce the username policy ourselves. UDENG-4517
adombeck
force-pushed
the
do-not-case-fold-username
branch
from
695c4aa to
4b7f8f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decision whether two usernames are considered equal is provider-specific. For example, some providers have case-insensitive usernames.
UDENG-4414
UDENG-4517