Update user info even on local authentication #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to rely on the cached information if the access token was still valid. Now, we always try to fetch the user information (username, groups, etc) if the session is online, even if we did not refresh the token.
didrocks
approved these changes
Sep 10, 2024
adombeck
reviewed
Sep 10, 2024
Comment on lines
+485
to
488
| if !session.isOffline { | ||
| authInfo.UserInfo, err = b.fetchUserInfo(ctx, session, &authInfo) | ||
| if err != nil { | ||
| slog.Error(err.Error()) |
There was a problem hiding this comment.
This has the effect that the we deny authentication when something goes wrong during refresh, even if the local token is still valid. I think it would be better to log the error and proceed with the login in that case.
There was a problem hiding this comment.
That's intended. If we want to refresh the user information every authentication, we need to fail if something goes wrong. IMO, we should not have "nondeterministic behavior" during the auth process. If we are online and intend on fetching user information from the provider, authentication should be denied if it's not possible to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to rely on the cached information if the access token was still valid. Now, we always try to fetch the user information (username, groups, etc) if the session is online, even if we did not refresh the token.
UDENG-4436