fix: Fix some issues with existing code #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didrocks
requested changes
Jan 24, 2024
didrocks
reviewed
Jan 26, 2024
didrocks
requested changes
Jan 26, 2024
The daemon used to rely on the executable name to define its internal name. This is far from ideal when dealing with tests (especially in parallel). Now, the New() function takes a name argument that allows setting a custom name for the daemon. This is very useful for tests.
This is a broker daemon, it should only know about its configuration and not about the general broker configuration directory
denisonbarbosa
force-pushed
the
daemon-fixes
branch
from
93d9a49 to
17f9602
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests that were not marked to fail were failing, so I took a look to understand why. Details for each fix are explained in the commit messages.