Minor broker refactorings #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adombeck
force-pushed
the
minor-broker-refactorings
branch
2 times, most recently
from
45d7496 to
c4cc7a6
Compare
denisonbarbosa
requested changes
Nov 18, 2024
denisonbarbosa
approved these changes
Nov 18, 2024
The "Info" suffix doesn't add any useful information.
The authConfig struct added an unnecessary level of nested structs.
Avoids the name clash between the Provider interface and the provider server.
To avoid the confusion between the provider interface and the provider server.
To avoid confusion with the Provider interface
These handlers only handle one endpoint of an OIDC provider.
adombeck
force-pushed
the
minor-broker-refactorings
branch
from
bc170f1 to
dfd7479
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for descriptions of the various changes.
UDENG-5453