Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Complete cmd/daemon unit tests #5

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

denisonbarbosa
Copy link
Member

There were some incomplete tests in the existing codebase. This finishes them so we can get our CI approval before getting started on the rest of the implementation.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@denisonbarbosa denisonbarbosa marked this pull request as ready for review January 30, 2024 12:15
@denisonbarbosa denisonbarbosa requested a review from a team as a code owner January 30, 2024 12:15
cmd/oidc-broker/daemon/daemon_test.go Show resolved Hide resolved
cmd/oidc-broker/daemon/daemon_test.go Outdated Show resolved Hide resolved
@denisonbarbosa denisonbarbosa requested review from didrocks and removed request for didrocks February 2, 2024 09:56
@denisonbarbosa denisonbarbosa merged commit f2de7b6 into main Feb 5, 2024
3 checks passed
@denisonbarbosa denisonbarbosa deleted the test-existing-code branch February 5, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants