Refactor dbusMenu Client #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can reuse it for menus too
Having the signals defined in the interface implies that gjs will connect to the g-signal events automatically doing GVariant unpacking that could be quite expensive in some cases (like in the menu event). So let's just ignore them all-together, we'll still get them manually when we care about, but we won't get anything done implicitly without our control.
3v1n0
force-pushed
the
refactor-menus-proxy
branch
from
4c7ea6a to
0296ce6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use base classes and optimize proxy so that we don't incur in gjs' automatic unpacking of big variants.