Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appIndicator: Try to introspect the application for Activate method support #524

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

3v1n0
Copy link
Collaborator

@3v1n0 3v1n0 commented Apr 18, 2024

Since its presence may lead to a delay to handle the double click, let's try to check early if the application supports it or not.

As per #519 (comment)

/cc @jingw @plumlis

…upport

Since its presence may lead to a delay to handle the double click, let's
try to check early if the application supports it or not.

Sadly the protocol does not explicitly state if this is supported, and
while it's normally true just for kde appindicators and not for the
ubuntu ones it's better to be generic
@3v1n0 3v1n0 force-pushed the activate-support-check branch from 305b9bf to 29acc70 Compare April 18, 2024 19:11
@3v1n0 3v1n0 merged commit c03e0c4 into master Apr 18, 2024
2 checks passed
@plumlis
Copy link

plumlis commented Apr 19, 2024

Thx, Looks good for trayicons for most applicaion(GTK,Electrom,wx)
But trayicons from qt application still have 0.5 sec latency.
Such as telegram, VLC,qbittorrent. Right click has no latency.

@3v1n0
Copy link
Collaborator Author

3v1n0 commented Apr 19, 2024

Sure, but there's no other way than waiting for a potential 2nd click if the app support it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants