Feat: add extra fields to "create user" (/admin/user) endpoint #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieterlukasse
changed the title
pieterlukasse
changed the title
pieterlukasse
force-pushed
the
feat/only_login_onboarded_users
branch
from
d33daa5
to
9d6b5b5
Compare
...to make user creation more uniform, reflecting what is also done elsewhere in fence/sync/sync_users.py _upsert_userinfo() for example
pieterlukasse
force-pushed
the
feat/add_extra_fields_to_admin_user_post
branch
from
ef1dac3
to
200c9da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/VADC-1350
Improvements
/admin/userPOST endpointto make user creation more uniform, reflecting what is also done elsewhere
in fence/sync/sync_users.py _upsert_userinfo() for example