Skip to content

Commit

Permalink
update to node vers 20.11.0 (#142)
Browse files Browse the repository at this point in the history
Co-authored-by: craigrbarnes <craigrbarnes@uchicago.edu>
  • Loading branch information
craigrbarnes and craigrbarnes authored Feb 19, 2024
1 parent 254fc05 commit 47b9bc9
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3.4.1
with:
node-version: 18.17.0
node-version: 20.11.0
- name: install npm version
run: npm install -g npm
- name: Get Version
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

FROM quay.io/cdis/ubuntu:20.04 as build

ARG NODE_VERSION=18
ARG NODE_VERSION=20

ENV DEBIAN_FRONTEND=noninteractive

Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
# CTDS Frontend Framework
# Gen3 Frontend Framework

## Installation

### Prerequisites

This is a multi-workspace repo that requires npm v9. The minimum node version is set to v18.15.0 only from an LTS perspective.
This is a multi-workspace repo that requires npm v9. The minimum node version is set to v20.11.0 only from an LTS perspective.

Node can be downloaded from the official Node.js site. You may also consider using a [Node version manager](https://docs.npmjs.com/cli/v7/configuring-npm/install#using-a-node-version-manager-to-install-nodejs-and-npm).

Your version of Node may not ship with npm v9. To install it, run:
Your version of Node may not ship with npm v10. To install it, run:

```bash
npm install npm@9.5.0 -g
npm install npm@10.2.4 -g
```

Note: if you see this error:
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
],
"engines" : {
"npm" : ">=10.2.3",
"node" : ">=18.17.0"
"node" : ">=20.11.0"
},
"scripts": {
"lint": "eslint .",
Expand Down

0 comments on commit 47b9bc9

Please sign in to comment.