-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD: Add CMake build option for tests and example C++ program #2036
Conversation
All the C programs build with this too? That's neat. Can you replace the existing makefile such that 'make' just invokes cmake? |
I don't think using make to invoke cmake is a good idea... It's a bit convoluted. |
Replacing it with build.sh is fine to me too. Note that many parts of the CI scripts call make, those would have to be changed to build.sh |
Co-authored-by: Cursor <hi@cursor.com>
Add support to build tests with CMake:
To build the programs, do
To clean the previous build, do
# cd ./tests/ cmake --build ./build/ --target clean
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?CI Help:
Add the following labels to modify the CI for a set of features.
Generally, a label added only affect subsequent changes to the PR (i.e. new commits, force pushing, closing/reopening).
See
ci:*
for full list of labels:ci:fpga-deploy
- Run FPGA-based E2E testingci:local-fpga-buildbitstream-deploy
- Build local FPGA bitstreams for platforms that are releasedci:disable
- Disable CI