par/innovus revert gds.gz output gds extension #880
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I understand this is space-efficient to export the final database as a
.gds.gz
, this change (introduced in 5e3cfb3 ) significantly breaks the hammer-intech22-plugin fill.mk and icv.mk scripts. See the image below regarding how it breaks the plugin.This PR reverts the change, so Innovus will export a
.gds
instead of.gds.gz
The fix could occur on either the hammer-intech22-plugin side, or here. I leave that to the maintainers to decide which is best ;)
Related PRs / Issues
N/A
Type of change:
Impact:
Contributor Checklist:
master
as the base branch?poetry.lock
file if you updated the requirements inpyproject.toml
?e2e/
if this feature depends on updated plugins?