Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image management updates + run_first script improvements #1617

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

clpetersonucf
Copy link
Member

@clpetersonucf clpetersonucf commented Oct 29, 2024

This spiral'd out after first noticing that the images in the base compose file don't actually exist, causing run_first to always build from source instead of pulling pre-built images for app and webserver.

Updates include:

  • Interactive prompt at the init of run_first to ask whether you want to pull precompiled images or build them from source
  • Removed some redundant steps from the run_first script
  • Renamed the app, webserver, and fakes3 images in the base compose file to their representative tags in the github package registry. They will default to the latest app-dev, webserver-dev, and fake-s3-dev accordingly.
  • Added app-stable and webserver-stable tags to published images for release builds.
  • Finally got around to updating the base mysql image from 5.7 to 8.0.32.

How to test

You'll need to kill your existing development instance of Materia, if present. Sorry about that.

If you had an existing Materia instance, do this first:

$ docker compose down
$ docker rmi -f $(docker images -q)

Then, in the docker/ directory of Materia:

$ ./run_first.sh

Choose option 1 for precompiled images. Choose option 2 to build the images locally.

Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modifications to the first run shell script work in both scenarios, and initial setup is way faster now when opting to use the existing images.

@clpetersonucf clpetersonucf merged commit 684f5e4 into dev/10.3.0 Oct 29, 2024
6 checks passed
@clpetersonucf clpetersonucf deleted the issue/1616-run-first-script-updates branch October 29, 2024 20:42
This was referenced Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants