Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlisted videos should be suggestions #431

Closed
bagofarms opened this issue Jun 28, 2019 · 3 comments
Closed

Unlisted videos should be suggestions #431

bagofarms opened this issue Jun 28, 2019 · 3 comments
Labels
easy enhancement
Milestone
v2.6.0

Comments

@bagofarms
Copy link
Member

Unlisted, private, and deleted videos are currently treated the same (with a "Manual verification required" message next to them). Instead, use the https://www.googleapis.com/youtube/v3/videos endpoint to determine the status of the video. If it is unlisted, ignore it for the videosEmbeddedOrLinkedNeedCaptions error and instead modify the videoUnlistedOrNotFound error in #255 to be a suggestion.
@bagofarms
Copy link
Member Author

Related to #200 and #2

@bagofarms bagofarms added this to the v2.7.0 milestone Jun 28, 2019
@bagofarms bagofarms mentioned this issue Jun 28, 2019
Closed
@bagofarms
Copy link
Member Author

To Do: Check Vimeo's documentation for the equivalent.

@jrsilveti
Copy link

Done. Pull request #438 has this fix.

@jrsilveti jrsilveti modified the milestones: v2.7.0, v2.6.0 Jul 18, 2019
@bagofarms bagofarms mentioned this issue Sep 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy enhancement
Projects
None yet
Milestone
v2.6.0
Development

No branches or pull requests
2 participants
@bagofarms @jrsilveti