Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/431 unlisted videos should be suggestions #438

Conversation

jrsilveti
Copy link

Merged Issue 200/ test for unavailable videos into dev/2-6-0.

Changed the errors for unlisted videos into suggestions.

@jrsilveti
Copy link
Author

Fixed unlisted videos showing up as an error and a suggestion.

@bagofarms bagofarms added this to the v2.7.0 milestone Jan 16, 2020
@bagofarms bagofarms changed the base branch from dev/v2-6-0 to dev/v2-7-0 January 16, 2020 04:27
@bagofarms bagofarms removed this from the v2.7.0 milestone Jan 16, 2020
@bagofarms
Copy link
Member

This got missed for 2.6.0 because it was missing the milestone. Moved to 2.7.0

@bagofarms bagofarms added this to the v2.7.0 milestone Jan 30, 2020
@bagofarms
Copy link
Member

Unfortunately, I'm going to have to close this issue without merging. I tested the code, and it works perfectly, but the same feature was implemented in a different way as part of checking for caption language in #434 . This only does a single API call rather than two, which is the primary reason for not merging this feature.

@bagofarms bagofarms closed this Sep 30, 2020
@bagofarms
Copy link
Member

Actually, I thought this over some more. We have API caching within the same scan, so adding this shouldn't result in any extra API usage. I will need to go in and remove the "manual check required" code from Ethan's code, though.

@bagofarms
Copy link
Member

Recreated in #547 so that I can make changes to the code.

@bagofarms bagofarms closed this Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants