-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/360 check caption language #434
Issue/360 check caption language #434
Conversation
squash 3de7cf1 added feature
3de7cf1
to
bda94dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My manual tests did not completely pass. While it was successful in detecting a mismatch in language, there is a major edge case that needs to be addressed. YouTube seems to use non-standard language codes for dialects. For example, a video from Univision will have captions with the language code es-MX
for "Spanish (Mexico)". Example: https://www.youtube.com/watch?v=FcnrUf35LmQ
Since there could be tons of dialects for languages, maybe the best approach would be to only look at the first two characters of the language that YouTube reports back.
Upgraded feature to not rely on config variables. Now just checks for the Canvas course language without any need for user setup. |
accounting for dialects lots of cleanup
c31cf33
to
d9ccbdc
Compare
Note: Remind users in release notes that dialects will be treated as being the same language |
I did some testing and found that way more YouTube API requests were being made than expected. I also talked to Matt about how we might be able to eliminate the extra API call for language by combining the two errors together and recognizing which one is which during the report building stage. |
added field limiting to vimeo checks testing api cache with vimeo
84e5a0a
to
3ccf4a3
Compare
Fixes #360