Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V18 #1056

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

V18 #1056

wants to merge 9 commits into from

Conversation

mizlan
Copy link
Member

@mizlan mizlan commented Jun 2, 2023

  • Move all actions/ to slices in reducers/ (Redux Toolkit)
  • Use middleware for syncing state for Firebase (?)
  • Add editor/ slice that manages ephemeral editor state
  • Remove all *Container components by using useSelector/useDispatch (Recommended way for React 16.8+)
  • Refactor all dispatches with the correct payload form (JS object)
  • Refactor state.programs from JS object to array (Redux state needs to be serializable)
  • Make sure basically all references to mostRecentProgram instead refer to a program(id?) prop, which is always in sync with the browser /editor/:programid (unnecessarily complex to keep them synced, likely to have bugs)
  • Bring back tests, using react-testing-library (Enzyme EOL at v16, necessary migration)

@netlify
Copy link

netlify bot commented Jun 2, 2023

Deploy Preview for sleepy-franklin-7a3e4c ready!

Name Link
🔨 Latest commit 5ae746b
🔍 Latest deploy log https://app.netlify.com/sites/sleepy-franklin-7a3e4c/deploys/647a37d04d94ab0008753a2a
😎 Deploy Preview https://deploy-preview-1056--sleepy-franklin-7a3e4c.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant