Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted the Switch.js to Switch.tsx #1092

Closed
wants to merge 2 commits into from

Conversation

tylerdtran
Copy link
Contributor

Typescript migration performed during the TeachLA Meeting

@netlify
Copy link

netlify bot commented Oct 25, 2023

👷 Deploy request for sleepy-franklin-7a3e4c pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 6feaeeb

@mizlan
Copy link
Member

mizlan commented Oct 25, 2023

Use imperative tense in commits.

eg Fix bug not Fixed bug

@mizlan
Copy link
Member

mizlan commented Oct 25, 2023

To change a pushed commit, amend it locally and then force push

@mizlan
Copy link
Member

mizlan commented Oct 25, 2023

Also fix the "Converted" commit message. This one might be a little trickier.

Also, going to push changes that will run a linter on TS files, since currently that isn't happening.

@mizlan
Copy link
Member

mizlan commented Oct 25, 2023

Linter stuff is pushed, please do the following:

  1. Pull and rebase the most recent changes (git pull --rebase)
  2. Install the new dependencies (npm i)
  3. Run npm lint-ts and fix any outstanding errors.

@tylerdtran tylerdtran closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants