-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added sketch thumbnail #181
Conversation
Syncing fork
Sketch Thumbnail is now displayed in editor mode.
Sketch thumbnail can now be viewed in code editor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think it looks good, this is solid work Nhi! Tentatively not approving on a minor CSS tidbit and a bit of thinking on the design of this. Interested to get some other people's opinions on this (@krashanoff , @jamieliu386 , @fan-matt - any thoughts)?
fixed small css bug when opening panel
Tested this locally w/ Nhi's fix and it seems like it works in Chrome & Firefox. Good catch Leo, I'll defer merging until you confirm that it's good on your end too! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked it out, nice work Nhi!
Sketch thumbnail of program can now be viewed in editor mode.