Adds link to GitHub Repo on 404 page, makes styling respect current theme #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krashanoff
reviewed
Feb 28, 2020
There was a problem hiding this comment.
Hey Matt, looks good, but when you mention the styling should respect the current theme, I only ever get the light themed error page. This was tested on the netlify deploy:
Then going to a nonexistent page:
Alternatively, going from light mode:
...to the same nonexistent page:
even if cookie doesn't exist, there are sensible defaults
Good catch! The theme itself wasn't actually working, so that makes lots of sense. Just added on a commit that should properly respect the theme. (in this case, I'm fine with pulling from |
krashanoff
approved these changes
Feb 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty small and quick PR. Adds a link to our GitHub repo on our 404 page (which might happen eventually with the view-only programs), and makes the page styling respect the current theme (with the
themifymixin). Also tidies up a bit of the underlying React code.(note: this should be squash merged, commit history is not too useful).