Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Login Page Design & Unifying Login/CreateUser #269

Merged
merged 17 commits into from
May 30, 2020
Merged

Conversation

mattxwang
Copy link
Member

@mattxwang mattxwang commented May 5, 2020

@emmyc killing the game 💯 (more docs coming soon)

to-do:

  • BUG: does not work on screens that are too tall/large
  • more above-the-fold content: re-add Teach LA logo, link to GH repo, link to main site
  • change accent color of button & inputs to page theme color
  • adjust create user to use similar style
  • add a bit more information to create user
  • better alt tags for image
  • fix "forgot your password" component - maybe this is a modal or another page?
  • new color button (optional but I think it'd be cool)

also, should we consider randomizing the SVG? just a thought 😮

and... tests?

and eventually, we should have a static feature page. probably out of scope for this PR!

@mattxwang mattxwang marked this pull request as draft May 5, 2020 05:13
adds alt tag, comments out unsued import, removes unused prop/social code
+ fixes issue where 5th image is never called
@krashanoff
Copy link
Contributor

Emmy the MVP 💯

All the changes are b e a u t i f u l as is, so I'm eager to roll this out when the remainder of the todo list is check off. I'll keep an eye on this going forward!

@mattxwang mattxwang changed the title [DRAFT] New Login Page Design New Login Page Design May 8, 2020
@mattxwang mattxwang changed the title New Login Page Design New Login Page Design & Unifying Login/CreateUser May 8, 2020
@mattxwang
Copy link
Member Author

Ok with that, we've hit everything on the to-do list other than the bugfix on large screens - @emmyc can you take a look at that when you have a chance.

Stretch goals should be adding some sort of testing, refactoring some of this code into util/helper functions, and making this much more mobile-friendly (though it does work as intended on mobile, just could be spicier). @krashanoff you can probably look to review/merge whenever.

@krashanoff krashanoff self-requested a review May 19, 2020 04:56
@mattxwang mattxwang added feature New feature or request refactor Refactoring & cleanup labels May 23, 2020
@mattxwang mattxwang marked this pull request as ready for review May 23, 2020 23:33
@mattxwang
Copy link
Member Author

@krashanoff just pushed a commit that should fix the svg not filling for the screen being too large, lmk what you think! I will say, the actual image itself looks slightly strange, but I think it's nbd.

As per super short screens & mobile, we probably do need to do something about it eventually - but also not sure as to what the plan is.

@krashanoff
Copy link
Contributor

Got it! Will check it out later this evening or tomorrow morning. Thanks Matt!

Regarding mobile screens, it isn't ideal, but it honestly isn't much worse than our current mobile experience:

image

We'll handle it another day.

Copy link
Contributor

@krashanoff krashanoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will probably have to go ahead and vertically center the image when working with tall viewports later on, but even in its current state things are looking an echelon above where things were at with our previous login page. I'd say this looks good to merge to me. Thanks a ton @malsf21 and @emmyc!

@krashanoff krashanoff merged commit dfbb280 into master May 30, 2020
@krashanoff krashanoff deleted the loginpage branch May 30, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request refactor Refactoring & cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants