Fixes Loading Page Timer Reference #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surprised I didn't catch this earlier - my fault!
krashanoff
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Leo gave his presentation with our code snippet, I realized that our code was not written the way it was intended.
Currently in
master, we had namespaced our timer inthis.setState.timer- not technically non-compiling code, but probably not what was intended.Instead, this PR moves the timer outside of state (since instantiating or re-calling the timer itself doesn't warrant a refresh), and moves it to a var called
this.timer.This should be a simple refactor that causes no functionality changes. We should test to verify this!