Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR that follows up #283 in applying policy fixes to our input validations. Here is an exhaustive list of the changes that I've proposed:
-_.
in the username, which is consistent with the username policies of many other websites. key thing to note here is this now invalidates@
in a username, which previously throws an error (as it can't be used in the LHS of an email address)correcthorsebatterystaple
) to the prevalence of password managers. Again, no technical issues here, as we aren't storing the password itself.-_.
(in addition to current policy) for display names.I am especially curious as to what our thoughts are on the username restriction; totally down to follow in the footsteps of Twitter or GitHub and allow for-
,_
,.
, etc.Also, this PR removes a duplicate set of tests for
CreateUserForm
that are already covered invalidate
.